Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Fix duplicate Agentuity keys in .env file creation#459

Merged
jhaynie merged 2 commits intomainfrom
devin/1759493838-fix-bun-dev-env-duplication
Oct 9, 2025
Merged

Fix duplicate Agentuity keys in .env file creation#459
jhaynie merged 2 commits intomainfrom
devin/1759493838-fix-bun-dev-env-duplication

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Oct 3, 2025 •
edited by coderabbitai Bot
Loading

Fix duplicate Agentuity keys in .env file creation

Summary

Fixes a bug where running agentuity dev creates duplicate AGENTUITY_SDK_KEY and AGENTUITY_PROJECT_KEY entries in the .env file with different values.

Root cause: When creating a new .env file, the dev command was:

  1. Writing ALL environment variables from project.Env and project.Secrets (including any existing AGENTUITY_* vars)
  2. Then explicitly writing AGENTUITY_SDK_KEY and AGENTUITY_PROJECT_KEY again

Solution: Filter out AGENTUITY_* prefixed variables using the existing envutil.IsAgentuityEnv regex before writing them to .env, preventing duplicates.

Review & Testing Checklist for Human

⚠️ This PR requires manual testing as the fix was not verified locally due to environment issues.

  • Test duplicate fix end-to-end: Delete .env file from a Bun project, run agentuity dev, verify no duplicate AGENTUITY_SDK_KEY/AGENTUITY_PROJECT_KEY entries
  • Verify regex pattern correctness: Confirm envutil.IsAgentuityEnv matches all intended AGENTUITY_* variables and nothing else
  • Test normal env var handling: Ensure non-Agentuity environment variables from cloud project still get written to .env correctly
  • Verify required keys present: Confirm AGENTUITY_SDK_KEY and AGENTUITY_PROJECT_KEY are still written as expected

Notes

  • The fix uses the same envutil.IsAgentuityEnv regex pattern already used elsewhere in the codebase for filtering (see internal/envutil/envutil.go lines 111-113, 187-189)
  • Originally reported by Rick Blalock (@rblalock) where bun run dev created random/duplicate SDK keys in .env
  • Devin session: https://app.devin.ai/sessions/2aba4f96b01e4015a890e34ad7e3085f

Summary by CodeRabbit

  • Bug Fixes

    • Prevents duplicate environment entries in generated .env when running dev, producing cleaner configs and avoiding potential conflicts.

  • Documentation

    • Updated changelog formatting with an Unreleased section and cleaned spacing for clarity.

@devin-ai-integration @rblalock
Fix duplicate Agentuity keys in .env file creation
ada9d45 
Filter out AGENTUITY_* prefixed environment variables from project.Env
and project.Secrets before writing to .env file to prevent duplicates.

The dev command was creating duplicate AGENTUITY_SDK_KEY and
AGENTUITY_PROJECT_KEY entries when running 'agentuity dev' because:
1. Lines 87-92 wrote ALL env vars including AGENTUITY_* vars from cloud
2. Lines 94-95 then wrote AGENTUITY_SDK_KEY and AGENTUITY_PROJECT_KEY again

This fix uses the existing envutil.IsAgentuityEnv regex pattern to filter
out Agentuity-prefixed variables, following the same pattern used
elsewhere in the codebase (envutil.go lines 111-113, 187-189).

Fixes issue reported in Slack where running 'bun run dev' created
duplicate/random SDK and project keys in .env file.

Co-Authored-By: Rick Blalock <rickblalock@mac.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration Bot commented Oct 3, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 3, 2025 •
edited
Loading

Walkthrough

The dev command’s .env generation now skips writing entries that match the Agentuity env pattern from both project.Env and project.Secrets; CHANGELOG.md had a formatting-only edit (removed an empty line).

Changes

Cohort / File(s) Summary
CHANGELOG formatting
CHANGELOG.md		 Removes a blank line between the "Public key encryption..." entry and the upcoming version header; purely formatting, no behavioral change.
Dev command .env generation
cmd/dev.go		 When emitting .env, skip writing keys that match envutil.IsAgentuityEnv from both project.Env and project.Secrets; still write AGENTUITY_SDK_KEY and AGENTUITY_PROJECT_KEY afterward.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant CLI as dev command
  participant CFG as Project Config (Env & Secrets)
  participant WR as .env Writer
  participant FILE as .env File

  Dev->>CLI: Run dev
  CLI->>CFG: Load Env and Secrets
  loop For each key/value in Env and Secrets
    CLI->>CLI: Check envutil.IsAgentuityEnv(key)?
    alt Matches Agentuity pattern
      CLI->>WR: Skip write for this key
    else Not a match
      WR->>FILE: Write KEY=VALUE
    end
  end
  note over CLI,WR: After iteration
  CLI->>WR: Write AGENTUITY_SDK_KEY
  CLI->>WR: Write AGENTUITY_PROJECT_KEY
  WR->>FILE: Append keys
  CLI-->>Dev: Done
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through envs with careful paws,
Skipping twins with regex laws.
Lines now tidy, no repeat—hooray!
One SDK, one Project—clean all day.
Thump-thump, the .env is neat and gay. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title clearly and succinctly identifies the main change by stating that it fixes duplicate Agentuity keys in the .env file creation process. It accurately reflects the bug and the intent of the code modifications without extraneous details. A reviewer scanning the history will understand the purpose of this PR at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1759493838-fix-bun-dev-env-duplication
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ada9d45 and e7fde9e.

📒 Files selected for processing (1)
  • CHANGELOG.md (0 hunks)
💤 Files with no reviewable changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build and Test (macos-latest)
  • GitHub Check: Analyze (go)

Comment @coderabbitai help to get the list of available commands and usage tips.

@jhaynie jhaynie merged commit 9ea7f71 into main Oct 9, 2025
14 checks passed
@jhaynie jhaynie deleted the devin/1759493838-fix-bun-dev-env-duplication branch October 9, 2025 21:25
@devin-ai-integration devin-ai-integration Bot mentioned this pull request Oct 10, 2025
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rblalock rblalock Awaiting requested review from rblalock

1 more reviewer

@jhaynie jhaynie jhaynie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rblalock rblalock

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhaynie @rblalock